Conversation
hmalik88
had a problem deploying
to
default-branch
GitHub Actions
Failure
ccharly
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This is needed to handle keyring controller locked scenarios when account creation is mid-flight in the multichain account service. Alternative was to do
KeyringController:getState, but I'd rather not pull in the whole state to do a boolean check.References
N/A
Checklist
Note
Low Risk
Low risk: adds a new read-only messenger action that returns the existing
state.isUnlockedboolean, with no changes to unlock/lock behavior or vault persistence.Overview
Adds a new
KeyringController:isUnlockedmessenger action so consumers can query vault lock status without fetching full controller state or holding a controller reference.This updates the allowed action types/exports and exposes
isUnlockedviaMESSENGER_EXPOSED_METHODS, with a changelog entry documenting the new capability.Reviewed by Cursor Bugbot for commit 83fffcb. Bugbot is set up for automated code reviews on this repo. Configure here.